Logic not working.

Can anybody tell me why the logic below wouldn't work.

{ This module controls the coach captain heat. Once the temp senor a set temp and winter start button or coach captains A/C on is activated then set high heat on }

once (GetLightingState("Winter") = ON)or
(GetLightingState("Coach captains A/C") = ON)and
(GetUnitParameter("Local",36,ptTemperature)<16) then
begin
SetLightingState("Coach captain high heat", ON);
SetLightingState("Coach captain low heat", ON);
SetLightingState("Coach captain fan",ON);
end;
{ This module controls the coach captain heat. Once the temp senor =
set temp and winter start button and coach captains A/C on is activated then set low heat on }

once (GetLightingState("Winter") = ON)or
(GetLightingState("Coach captains A/C") = ON)and
(GetUnitParameter("Local",36,ptTemperature)>=16) then
begin
SetLightingState("Coach captain high heat", OFF);
SetLightingState("Coach captain low heat", ON);
SetLightingState("Coach captain fan",ON);
end;
{ This module controls the coach captain heat. Once the temp senor =
set temp and winter start button and coach captains A/C on is activated then set all heat off }

once (GetLightingState("Winter") = ON)or
(GetLightingState("Coach captains A/C") = ON)and
(GetUnitParameter("Local",36,ptTemperature)>22) then
begin
SetLightingState("Coach captain high heat", OFF);
SetLightingState("Coach captain low heat", OFF);
SetLightingState("Coach captain fan",OFF);
end;
{ This module controls the coach captain heat. Once winter start button and coach captains A/C is off then set
all heat off }


once (GetLightingState("Winter") = OFF) and
(GetLightingState("Coach captains A/C") = OFF) then
begin
SetLightingState("Coach captain high heat", OFF);
SetLightingState("Coach captain low heat", OFF);
SetLightingState("Coach captain fan", OFF);
end;

 

You could probably use some extra brackets in the AND/OR statements, as I'm not sure of the precedence the compiler uses. eg.

Is it:

Code:

(A or B) and C

or

Code:

A or (B and C)

...and that will at least make the intent of those logic statements a bit clearer.

I guess it may also not work if the temp sensor is not working properly - you can use the GetUnitParamStatus(Network, UnitAddress, ParameterType) to make sure you're getting a valid reading back.

OR its something more obvious that I can't see!

Anyway, hope that's some help.

Cheers

Matt

 

code not working

Would it be better to do it like this ?


If (GetLightingState("Winter") = ON) or (GetLightingState("Coach captains A/C") = ON) Then
begin

Once (GetUnitParameter("Local",36,ptTemperature) < 16) then
begin
SetLightingState("Coach captain high heat", ON);
SetLightingState("Coach captain low heat", ON);
SetLightingState("Coach captain fan",ON);
end;

{ This module controls the coach captain heat. Once the temp senor =
set temp and winter start button and coach captains A/C on is activated then set low heat on }

Once (GetUnitParameter("Local",36,ptTemperature) >= 16) And (GetUnitParameter("Local",36,ptTemperature) <= 22) then
begin
SetLightingState("Coach captain high heat", OFF);
SetLightingState("Coach captain low heat", ON);
SetLightingState("Coach captain fan",ON);
end;

{ This module controls the coach captain heat. Once the temp senor =
set temp and winter start button and coach captains A/C on is activated then set all heat off }

once (GetUnitParameter("Local",36,ptTemperature) > 22) then
begin
SetLightingState("Coach captain high heat", OFF);
SetLightingState("Coach captain low heat", OFF);
SetLightingState("Coach captain fan",OFF);
end;

{ This module controls the coach captain heat. Once winter start button and coach captains A/C is off then set
all heat off }

End;

once (GetLightingState("Winter") = OFF) and (GetLightingState("Coach captains A/C") = OFF) then
begin
SetLightingState("Coach captain high heat", OFF);
SetLightingState("Coach captain low heat", OFF);
SetLightingState("Coach captain fan", OFF);
end;

 

Thanks.

Thanks Matt,
I have soughted the problem with your input. Still cant see why it didn't work with Get unit parameter. The brackets around the or statements I totally forgot about.
Thanks again.